Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support stringify BigInt #587

Merged
merged 2 commits into from
Sep 13, 2024
Merged

support stringify BigInt #587

merged 2 commits into from
Sep 13, 2024

Conversation

ahaoboy
Copy link
Contributor

@ahaoboy ahaoboy commented Sep 13, 2024

Description of changes

support stringify BigInt

JSON.stringify({
  v: 1n,
})
// TypeError: Do not know how to serialize a BigInt

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

richarddavison
richarddavison approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@richarddavison richarddavison merged commit 43417a0 into awslabs:main Sep 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richarddavison richarddavison richarddavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahaoboy @richarddavison